Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update s element mapping #442

Merged
merged 5 commits into from
Dec 12, 2022
Merged

update s element mapping #442

merged 5 commits into from
Dec 12, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Oct 19, 2022

closes #416

revises the <s> element to map to ARIA's deletion role, rather than having no implicit ARIA mapping. Introducing this mapping would allow for browsers to expose this role, and thus AT to better communicate that the content is marked as no longer relevant. Presently authors need to employ visually hidden content to programmatically convey what the element visually represents with its default UA CSS strike-through.

Implementation requests:


Preview | Diff

closes #416 

revises the `<s>` element to map to ARIA's `deletion` role, rather than having no implicit ARIA mapping.
Introducing this mapping would allow for browsers to expose this role, and thus AT to better communicate that the content is marked as no longer relevant.  Presently authors need to employ visually hidden content to programmatically convey what the element visually represents with its default UA CSS strike-through.
@jcsteh
Copy link

jcsteh commented Oct 20, 2022

Presently authors need to employ visually hidden content to programmatically convey what the element visually represents with its default UA CSS strike-through.

Just for the sake of clarity, authors could also use role="deletion" rather than visually hidden content.

@scottaohara
Copy link
Member Author

scottaohara commented Oct 20, 2022

Thank you for the clarifying comment @jcsteh. Yes, my comment was meant to allude to practices that have been promoted prior to that role’s wider implementation, and the fact that there is a “semantic” difference between the html del and s elements. I have a minor companion Pr to edit the aria spec so that the deletion role definition covers both use cases for the different html elements.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, btw!

@scottaohara
Copy link
Member Author

I'm going to merge this since it's been picked up by @spectranaut for implementation in chromium, and Firefox has marked the bug as an enhancement.

@scottaohara scottaohara merged commit 2de152d into gh-pages Dec 12, 2022
@scottaohara scottaohara deleted the s-element-mapping-update branch December 12, 2022 22:46
Copy link
Collaborator

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Better late than never.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider mapping <s> element to role=deletion
4 participants