-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update s element mapping #442
Conversation
closes #416 revises the `<s>` element to map to ARIA's `deletion` role, rather than having no implicit ARIA mapping. Introducing this mapping would allow for browsers to expose this role, and thus AT to better communicate that the content is marked as no longer relevant. Presently authors need to employ visually hidden content to programmatically convey what the element visually represents with its default UA CSS strike-through.
Just for the sake of clarity, authors could also use |
Thank you for the clarifying comment @jcsteh. Yes, my comment was meant to allude to practices that have been promoted prior to that role’s wider implementation, and the fact that there is a “semantic” difference between the html del and s elements. I have a minor companion Pr to edit the aria spec so that the deletion role definition covers both use cases for the different html elements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, btw!
I'm going to merge this since it's been picked up by @spectranaut for implementation in chromium, and Firefox has marked the bug as an enhancement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Better late than never.
closes #416
revises the
<s>
element to map to ARIA'sdeletion
role, rather than having no implicit ARIA mapping. Introducing this mapping would allow for browsers to expose this role, and thus AT to better communicate that the content is marked as no longer relevant. Presently authors need to employ visually hidden content to programmatically convey what the element visually represents with its default UA CSS strike-through.Implementation requests:
Preview | Diff